Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in Python client #480

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Improve logging in Python client #480

merged 2 commits into from
Jul 10, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 6, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For #236

cc @taxpon @frol @mbohlool @cbornet @kenjones-cisco

@asqui
Copy link

asqui commented Jul 6, 2018

Your changes to resources/python/configuration.mustache look good to me but not sure why there are 64 other files changed in the same commit.

Looks like that might be the result of re-generating the petstore sample, in which case it might be better to commit the results of that separately?

@wing328
Copy link
Member Author

wing328 commented Jul 6, 2018

@asqui the updated Petstore samples need to be included in this PR so that the CI can test the changes in the Python petstore clients.

@kenjones-cisco
Copy link
Contributor

LGTM! Thanks @wing328

@asqui
Copy link

asqui commented Jul 6, 2018

@wing328 I understand that, but what I don't understand is how all those petstore example changes are at all related to your code change.

@wing328
Copy link
Member Author

wing328 commented Jul 6, 2018

@asqui good question. The Python samples may not be up-to-date due to new test cases added to the test spec.

@grokify
Copy link
Member

grokify commented Jul 6, 2018

@asqui Would having 2 commits in this PR satisfy your concern in the future? For example, one commit could be the client code changes and another commit could be the updated samples. This way the two commits could be viewed separately while also including the updated samples for testing.

@wing328
Copy link
Member Author

wing328 commented Jul 10, 2018

The CircleCI error is not related.

@wing328 wing328 merged commit 0d952b7 into master Jul 10, 2018
@wing328 wing328 deleted the fix_236 branch July 10, 2018 14:12
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* improve logging in python client

* update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants