-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging in Python client #480
Conversation
Your changes to Looks like that might be the result of re-generating the petstore sample, in which case it might be better to commit the results of that separately? |
@asqui the updated Petstore samples need to be included in this PR so that the CI can test the changes in the Python petstore clients. |
LGTM! Thanks @wing328 |
@wing328 I understand that, but what I don't understand is how all those petstore example changes are at all related to your code change. |
@asqui good question. The Python samples may not be up-to-date due to new test cases added to the test spec. |
@asqui Would having 2 commits in this PR satisfy your concern in the future? For example, one commit could be the client code changes and another commit could be the updated samples. This way the two commits could be viewed separately while also including the updated samples for testing. |
The CircleCI error is not related. |
* improve logging in python client * update samples
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.Description of the PR
For #236
cc @taxpon @frol @mbohlool @cbornet @kenjones-cisco