[Golang][client] fix CacheExpires ineffassign, Fix #464 #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.1.x
,4.0.x
. Default:master
.@antihax
@bvwells
Description of the PR
fix #464
client.go
has an ineffectual if statement in theCacheExpires
function. This results in a lower score on Go Report Card for the generated code described here: #464 . Go Report Card is a commonly used app with it's shield on many GitHub repo READMEs.Here is an example:
https://goreportcard.com/report/github.com/grokify/go-stackexchange
Two options to resolve this include:
Option 1
Option 2
This option works because an error will return a
0s
duration, but it may be better to not rely on this behavior.Either approach will resolve the issue on Go Report Card for the generated code.
This PR uses option 1 since it is easier to understand, explicitly handles the error and is similar to other error handling in the function.