[Golang][client] fix CacheExpires ineffassign, Fix #464

[grokify]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax
@bvwells

Description of the PR

fix #464

client.go has an ineffectual if statement in the CacheExpires function. This results in a lower score on Go Report Card for the generated code described here: #464 . Go Report Card is a commonly used app with it's shield on many GitHub repo READMEs.

Here is an example:

https://goreportcard.com/report/github.com/grokify/go-stackexchange

Two options to resolve this include:

Option 1

lifetime, err := time.ParseDuration(maxAge + "s") 
if err != nil {
    expires = now
} else {
    expires = now.Add(lifetime)
}

Option 2

This option works because an error will return a 0s duration, but it may be better to not rely on this behavior.

lifetime, _ := time.ParseDuration(maxAge + "s")
expires = now.Add(lifetime)

Either approach will resolve the issue on Go Report Card for the generated code.

This PR uses option 1 since it is easier to understand, explicitly handles the error and is similar to other error handling in the function.

[wing328]

The change looks good to me 👍