fix: The values for @Produces annotation were not separated by a comma. #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug found with jaxrs-resteay source code.
|
@tnmtechnologies: thank you a lot for this PR! Great job. I took the liberty to add a unit test that correspond to the case you have fixed (inspired by what you have posted in #443). I will merge this PR when the CI Job are green. |
jmini
approved these changes
Jul 3, 2018
|
Thank you too. Happy to know it helps. |
tnmtechnologies
deleted the
fix/produces-annotation-multiples-values-not-separated-by-comma
branch
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…ed by a comma (OpenAPITools#445) * fix: The values for @produces annotation were not separated by a comma. * Add test case for OpenAPITools#443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Bug found with jaxrs-resteay source code.
Issue #443
Description of the PR
Before adding a new mediaType into the produces list, we put a ["hasMore", "true"] to the last mediaType in order to be sure "hasMore" value is "true" because in some situations, "hasMore" value in the map was null.