Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Kotlin formatting issues and make source more Kotlin like #427

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Fix some Kotlin formatting issues and make source more Kotlin like #427

merged 1 commit into from
Jul 3, 2018

Conversation

guenhter
Copy link
Contributor

@guenhter guenhter commented Jul 1, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@jimschubert

The generated code had a few formatting issues (like too deep indentation).
Also some things are done a little bit differently (like using when instead if-else-cascade).

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@wing328
Copy link
Member

wing328 commented Jul 1, 2018

@guenhter thanks for the PR.

Shall we use something like https://github.com/shyiko/ktlint to check the Kotlin's code format?

@guenhter
Copy link
Contributor Author

guenhter commented Jul 1, 2018

That's not a bad idea. Could really help to keep the code properly formatted.

@jmini jmini merged commit c1eda61 into OpenAPITools:master Jul 3, 2018
@jmini
Copy link
Member

jmini commented Jul 3, 2018

Thank you a lot for this contribution.


Shall we use something like https://github.com/shyiko/ktlint to check the Kotlin's code format?
That's not a bad idea. Could really help to keep the code properly formatted.

Please file an other PR for that or at least an issue in order to keep the idea in the TODO list.

@guenhter guenhter deleted the fix-kotlin-formatting branch July 3, 2018 06:58
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants