Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline between function signature of operation and summary of operation #4112

Merged
merged 4 commits into from
Oct 15, 2019

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Oct 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Added newline so that the summary doesn't appear at the same line as the function signature.

@zippolyte
Copy link
Contributor Author

@wing328 wing328 merged commit 3693d60 into OpenAPITools:master Oct 15, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 15, 2019
@zippolyte zippolyte deleted the hippo/go_summary branch October 15, 2019 08:48
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@zippolyte thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants