Improve generation of README which has long description #400
Conversation
| * @param input String to be escaped | ||
| * @return escaped string | ||
| */ | ||
| public String escapeTextWhileAllowingNewLines(String input) { |
There was a problem hiding this comment.
almost duplicated with escapeText. Please let me know if you know better idea. 💦
There was a problem hiding this comment.
Technically we can add another parameter to escapeText (similar to camelize) but that probably will require code updates in lots of places.
Let's go with this solution for the time being.
|
@OpenAPITools/generator-core-team |
|
I think my attempt to resolve the conflict online (using Github web-based GUI) introduces some issues. I'll fix it locally and push out a fix soon. |
|
Thanks for resolving the conflicts! I noticed that I missed the case of empty description. 👀 I'll push a commit soon. |
|
Not related to this PR, but there's the diffs on results of so ran the script locally and pushed commit. |
…#400) * Add `appDescriptionWithNewLines` * Add test case for escapeText as well * Ruby client allows new lines in README * Add doc comment * fix issue related to github web gui * the case of no description provided * Run `./bin/utils/ensure-up-to-date` https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/1118/1/console
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
issue: #369
Added
{{appDescriptionWithNewLines}}tag which allows new lines.