[aspnetcore] Fix new keyword collection #385
Conversation
| @@ -58,7 +58,7 @@ | |||
| public Set<String> allMandatory; | |||
|
|
|||
| public Set<String> imports = new TreeSet<String>(); | |||
| public boolean hasVars, emptyVars, hasMoreModels, hasEnums, isEnum, hasRequired, hasOptional, isArrayModel, hasChildren; | |||
| public boolean hasVars, emptyVars, hasMoreModels, hasEnums, isEnum, hasRequired, hasOptional, isArrayModel, hasChildren, isCollectionModel; | |||
There was a problem hiding this comment.
(I may be wrong as I'm new to aspnetcore)
How about add isMapModel instead of isCollectionModel?
I think isCollectionModel is a bit complicated: It is ArraySchema and also MapSchema.
To keep our project as simple as possible, I think isMapModel may be better.
For template creator:
- in case of treating ArraySchema =>
{{isArrayModel}} - in case of treating MapSchema =>
{{isMapModel}} - in case of treating something collection =>
{{isArrayModel}}&{{isMapModel}}
Assuming that isMapModel exists, it is a good idea to add isCollectionModel as it can be possible handling some collection models transparently. But if we can satify our requirements without it for now, we need to postpone.
|
Will merge this at the end of the day if there is no more comment :) |
|
@JFCote: I have added milestone |
|
@jmini Oups sorry, that was my first merge. I've taken note of this and will take care of that next time! Thanks! |
|
;) |
|
@JFCote: No worry and thank you a lot for merging PRs. Please continue to merge stuff you are comfortable with. An other feedback, in this project we tend to prefer the "Squash and merge" option on GitHub:
The debate about which option to select is infinite. There are pro and contra for each way. What matters the most to me: we try to all work the same way. This produce a certain homogeneity in the project. |
|
Added this PR to 3.0.3 release note. |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
Add
isMapModeltoCodegenModelto allow distinguishing if a Model is inherited fromICollection.Small refactor in
model.mustacheto allow removal of some VS hints.Solves #275
@mandrean @jimschubert
cc core team for
DefaultCodegenandCodegenModelChanges@wing328 @jimschubert @cbornet @jaz-ah @ackintosh @JFCote @jmini