Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] version in the generated README dependent from {{java8}} #380

Merged
merged 3 commits into from
Jul 4, 2018

Conversation

developersteve
Copy link
Contributor

@developersteve developersteve commented Jun 22, 2018

Same issue as per swagger-api/swagger-codegen#7259 just need to update the README

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@jmini
Copy link
Member

jmini commented Jun 22, 2018

To run OpenAPI-Generator itself you need Java 8. The main Reame in this project says so.

But the file you are modifying is for the Readme of the generated project. I did not check in detail, but I think that with some option you manage to get a generated project that can be built with "Java 6".

I think in the mustache readme the output should be dependent from if the java8 option is true or false.

@wing328
Copy link
Member

wing328 commented Jul 3, 2018

@developersteve which Java API client (e.g. jersey2, okhttp-gson, etc) are you using? I believe most still work with Java 7.

@jmini
Copy link
Member

jmini commented Jul 3, 2018

@wing328 exactly I believe this too... Unless you set the java8 option during generation (See AbstractJavaCodegen.setJava8Mode(boolean) in the code).

Maybe we could/should make the README dependent of the {{java8}} variable.

@jmini
Copy link
Member

jmini commented Jul 4, 2018

I have update this PR to consider {{java8}}

@jmini jmini added this to the 3.1.0 milestone Jul 4, 2018
@jmini jmini changed the title JDK1.7+ is no longer supported by SDK generation [Java] version in the generated README dependent from {{java8}} Jul 4, 2018
@jmini jmini merged commit 020883f into OpenAPITools:master Jul 4, 2018
@jmini jmini mentioned this pull request Jul 4, 2018
4 tasks
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants