Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] Add processing of Port defined in spec #368

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

etherealjoy
Copy link
Contributor

@etherealjoy etherealjoy commented Jun 21, 2018

PR checklist

  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
  • Read the contribution guidelines.

Description of the PR

Port defined in the spec is processed so that the server is accessible on a predefined port stated in spec instead of default Kestrel port 5000

Listening on 0.0.0.0 is needed to make the server accessible not only when it is running on host but also inside a docker container.

@mandrean @jimschubert

@etherealjoy
Copy link
Contributor Author

etherealjoy commented Jun 22, 2018

Should I fix it in DefaultCodegen instead so that the mustache variable is updated for all subclass?

@etherealjoy etherealjoy reopened this Jul 2, 2018
@jmini
Copy link
Member

jmini commented Jul 3, 2018

Should I fix it in DefaultCodegen instead so that the mustache variable is updated for all subclass?

The problem is that a lot of existing codegen are doing this there own way (other default values, possibility to override the value with an additional property on the CLI...). It will be difficult to generalize it in DefaultCodegen.

@jmini jmini merged commit bece8d2 into OpenAPITools:master Jul 3, 2018
@jmini jmini added this to the 3.1.0 milestone Jul 3, 2018
@etherealjoy etherealjoy deleted the aspnet_add_parsing_port branch July 3, 2018 08:16
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants