openapi-generator-gradle-plugin-mvn-wrapper should not be uploaded #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Gitter:
|
|
Verified in the distant repo: openapi-generator-gradle-plugin-mvn-wrapper All other projects: (example with openapi-generator core): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
modules/openapi-generator-gradle-plugin/pom.xmldefines theopenapi-generator-gradle-plugin-mvn-wrapperthat is just a maven pom to start gradle. Gradle is creating, installing, and deploying the realopenapi-generator-gradle-pluginartifact.The idea of #202 was to create this artifact and to prevent to install and to deploy the
openapi-generator-gradle-plugin-mvn-wrapper.In some travis log you see:
Example: https://api.travis-ci.org/v3/job/394868611/log.txt
But this does not work, because you see the artifact online:
https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-gradle-plugin-mvn-wrapper/3.0.3-SNAPSHOT/
And also on maven central:
http://central.maven.org/maven2/org/openapitools/openapi-generator-gradle-plugin-mvn-wrapper/
So I had to figure out what went wrong.
In this log you see: https://api.travis-ci.org/v3/job/394867936/log.txt
This PR:
maven-install-pluginand ofmaven-deploy-pluginby disabling the plugins atpluginManagementsection (instead of thebuildsection). See https://stackoverflow.com/questions/12751724/can-i-modify-the-maven-deploy-phase-to-replace-the-maven-deploy-plugin-with-my-oskipNexusStagingDeployMojototruein order to prevent theopenapi-generator-gradle-plugin-mvn-wrapperto be handled by thenexus-staging-maven-plugin. Read more here: https://stackoverflow.com/questions/25305850/how-to-disable-nexus-staging-maven-plugin-in-sub-modules