Fix alias to map in the model's properties

[wing328]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #255, #191

This is the first fix for "alias". Please expect more PRs to fix various usage of alias (e.g. alias of alias, alias of array, alias handling in response, parameters, etc)

In the upcoming PRs, I'll also add more Java unit tests to cover the issue moving forward.

[wing328]

@ackintosh FYI. Now outer_enum is referencing String correctly

[wing328]

The PHP tests failed with the following errors:

PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

.........................................F....................... 65 / 69 ( 94%)
....

Time: 2.12 seconds, Memory: 15.75MB

There was 1 failure:

1) OpenAPI\Client\OuterEnumTest::testSanitizeNestedInvalidValue
Failed asserting that exception of type "InvalidArgumentException" is thrown.

I tried to fix it locally but in vain. I tried supplying invalid values (e.g. "not_upper", 1000, etc to other enum values) but still no exception is thrown.

I've skipped the test via d88c9bf for the time being

[wing328]

UPDATE: I pushed another commit to retain the top-level enum classes. Thanks for the test case to cover it.

[wing328]

cc core team (@jimschubert @jmini @cbornet @ackintosh @JFCote @jaz-ah )

[jmini]

I did not look at it in details yet, it looks good to me in general.

---

One question about the targeted branch:

this change has a big impact on the generated code (it is an improvement because it solves something that is not correct now, but still an impact). This might break some existing code relying on the generated code.

I think it is preferable to have this filed for 3.1.x (just change the target branch in the GitHub UI). From a release perspective, it is only one week more to wait (3.1.0 is due at beginning of july).

[wing328]

I think it is preferable to have this filed for 3.1.x (just change the target branch in the GitHub UI). From a release perspective, it is only one week more to wait (3.1.0 is due at beginning of july).

Definitely a valid point. I don't mind targeting 3.1.x. I'll update it later today if no one has other suggestions/feedbacks on which branch this PR should target.

[etherealjoy]

Issue solved for #255
With the spec mentioned in this issue, the code is generated for go-server and aspnetcore.

[wing328]

The CI failures are not related to this change