Restore unit test #346
Merged
Restore unit test #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add copy command in *.sh scripts
and add copy command in *.sh scripts
and add copy command in *.sh scripts
and add copy command in *.sh scripts
and add copy command in *.sh scripts
and add copy command in *.sh scripts
and add copy command in *.sh scripts
wing328
approved these changes
Jun 20, 2018
|
@jmini thanks for restoring the test 👍 |
|
As explained in #247 there is a second part that consist of also restoring the manually written implementation. Now that is is merged I will work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #247 the Java-clients samples contain unit-test code that is not generated but that is just added and executed by our CI.
This PR restores the tests that were removed with c8c316e.
Because we want to be able to recreate
samplesfrom scratch, the manually written files are added to theCI/samples.cifolder and copied to thesamplesfolder at the end of the*.shscript.