Grammar and spelling fixes #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Jun 16, 2018
| @@ -250,7 +250,7 @@ ce930e7a6 [Jaxrs-cxf] Add bean-level cascaded beanvalidation for pojos (@Valid) | |||
| ff1178ad7 [Java][Spring] fix missing optional query params | |||
| 2103fadab Fix package declaration for play-framework | |||
| 2c6380c84 fix inner item (list, map) for play framework | |||
| e33b350c8 Fix an issue in Play Framework generator where a CSV is empty and transfered to the controllerImp with an empty item. | |||
| e33b350c8 Fix an issue in Play Framework generator where a CSV is empty and transferred to the controllerImp with an empty item. | |||
There was a problem hiding this comment.
@scop thanks. I've updated the release note in https://github.com/OpenAPITools/openapi-generator/releases/tag/v3.0.0 accordingly
|
After updating the samples, the Shippable tests passed: https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/862/summary/. I'll file a separate PR to update the samples. |
wing328
approved these changes
Jun 16, 2018
|
Yeah, seeing that the samples were already quite outdated at least to some extent, I opted to not touch them here. Thanks for taking care of that. |
|
@scop no problem. Thanks again for the PR. Have a nice weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
Grammar and spelling fixes.