Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go server clean up #328

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Go server clean up #328

merged 1 commit into from
Jun 17, 2018

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Jun 15, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Clean up go server.

  • Make sure logger is go formatted.
  • Add golint valid documentation for exported API functions.

@antihax

@@ -6,6 +6,7 @@ import (
"net/http"
){{#operation}}

// {{nickname}} - {{summary}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using {{{summary}}} without encoding HTML special characters

@bvwells
Copy link
Contributor Author

bvwells commented Jun 16, 2018

@wing328 thanks for the review. I've updated to use {{{summary}}}.

@wing328 wing328 merged commit c51986d into OpenAPITools:master Jun 17, 2018
@bvwells
Copy link
Contributor Author

bvwells commented Jun 17, 2018

Thanks @wing328 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants