Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang][client] Add test for client.StoreApi.PlaceOrder() #321

Merged
merged 1 commit into from
Jun 14, 2018
Merged

[Golang][client] Add test for client.StoreApi.PlaceOrder() #321

merged 1 commit into from
Jun 14, 2018

Conversation

grokify
Copy link
Member

@grokify grokify commented Jun 14, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add passing test for Petstore POST /v2/store/order - client.StoreApi.PlaceOrder().

  • Uses same values as default Petstore UI
  • Uses UTC "Z" timezone. Local offset, e.g. -07:00, returns 500 error from Petstore API server. This type of Local Offset is specified in RFC-3339

@antihax
@bvwells

@wing328
Copy link
Member

wing328 commented Jun 14, 2018

Tests passed locally and in CircleCI as well: https://circleci.com/gh/OpenAPITools/openapi-generator/681.

Thanks for the enhancement!

@wing328 wing328 merged commit 7126074 into OpenAPITools:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants