Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] Enabling XML documentation on csharp-netcore client #2996

Merged
merged 7 commits into from
May 26, 2019

Conversation

saigiridhar21
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

#2952

@saigiridhar21 saigiridhar21 changed the title Csharp netcore issue 2593 [csharp-netcore] Enabling XML documentation on csharp-netcore client May 25, 2019
@wing328 wing328 added this to the 4.0.1 milestone May 26, 2019
@wing328
Copy link
Member

wing328 commented May 26, 2019

LGTM

cc @mandrean (2017/08), @jimschubert (2017/09) 

@wing328 wing328 merged commit d0a8d68 into OpenAPITools:master May 26, 2019
@saigiridhar21 saigiridhar21 deleted the csharp-netcore-issue-2593 branch May 27, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants