Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][okhttp-gson] Include API's Http response codes and their corresponding description and response headers in the documentation #2995

Merged

Conversation

saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented May 25, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

#2994

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog

@auto-labeler
Copy link

auto-labeler bot commented May 25, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 499c8ac into OpenAPITools:master May 28, 2019
@saigiridhar21 saigiridhar21 deleted the okhttpgson-java-documentation branch May 29, 2019 08:14
@wing328 wing328 changed the title [java-okhttpgson]: Include API's Http response codes and their corresponding description and response headers in the documentation [Java][okhttp-gson] Include API's Http response codes and their corresponding description and response headers in the documentation May 31, 2019
@jmini
Copy link
Member

jmini commented Jul 8, 2019

@saigiridhar21: this @http.response.details you have introduced is causing me trouble when I try to generate the javadoc:
#3299

Can you give me some input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants