Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ server scripts/batch files #296

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Update C++ server scripts/batch files #296

merged 1 commit into from
Jun 13, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jun 13, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

#250 follow up

@wing328
Copy link
Member Author

wing328 commented Jun 13, 2018

@MartinDelille
Copy link
Contributor

This Circle CI/Shippable thing is slowing down our validation process.

@wing328
Copy link
Member Author

wing328 commented Jun 13, 2018

For CircleCI, moving to CircleCI 2.0 infra may improve the run time of the build.

For Shippable, no obvious solution off the to top of my head at the moment (well it's free and we appreciate shippable providing CI to us at no cost)

@wing328 wing328 merged commit 49b8ece into master Jun 13, 2018
@wing328 wing328 deleted the followup_250 branch June 13, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants