Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Fix group parameters in WithHttpInfo method #2951

Merged
merged 2 commits into from
May 22, 2019
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 21, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #2945

@ypereirareis
Copy link

Hi, your fix seens ok to me !
Thanks for your reactivity. 😃

Is there a binary or docker image for this PR so I can test it and give you some feedback ?

Bye.

@wing328
Copy link
Member Author

wing328 commented May 21, 2019

Is there a binary or docker image for this PR so I can test it and give you some feedback ?

Unfortunately, pulling the branch and building the JAR locally is the only way.

@ypereirareis
Copy link

Ok I can do this easily with a docker image if you give me the process or command line and requirements to build the JAR. I can build it (build a Makefile or so) and give you my work after that so you can add it in the project for future PRs.

@wing328
Copy link
Member Author

wing328 commented May 21, 2019

Let's have the PHP technical committee review it before merging it into master.

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)

@wing328 wing328 changed the title [PHP] Fix group parameter in withHttpInfo method [PHP] Fix group parameter in WithHttpInfo method May 21, 2019
@wing328 wing328 changed the title [PHP] Fix group parameter in WithHttpInfo method [PHP] Fix group parameters in WithHttpInfo method May 21, 2019
@wing328 wing328 merged commit be8c5fa into master May 22, 2019
@wing328 wing328 deleted the php_fix_group branch May 22, 2019 10:21
@wing328
Copy link
Member Author

wing328 commented May 22, 2019

@ypereirareis the fix has been merged into master. Please try it later when the docker image/JAR snapshot version is available.

@ypereirareis
Copy link

Good job !! Thanks 👍 👍 👍 👍 👍

@ypereirareis
Copy link

I tested the latest docker image, and everything is ok now. Your fix fixed my bug. Thanks !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][PHP] x-group-parameters with bad/weird behavior
2 participants