Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2022 util._deserialize throws AttributeError in Python 3.7 #2918

Closed
wants to merge 1 commit into from

Conversation

bejohu
Copy link

@bejohu bejohu commented May 16, 2019

No description provided.

@wing328
Copy link
Member

wing328 commented May 20, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented May 20, 2019

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01)

@wing328
Copy link
Member

wing328 commented May 20, 2019

@bejohu Is this fixing the same issue as #2884 ?

@GuillaumeSmaha
Copy link
Contributor

@wing328 Yes, this is the same issue.
I tried without typing-inspect because I saw https://github.com/ilevkivskyi/typing_inspect doesn't support python 3.5

@wing328
Copy link
Member

wing328 commented May 20, 2019

@GuillaumeSmaha 👌

@bejohu can you test #2884 to see if it works for you as well?

git checkout -b GuillaumeSmaha-fix_python_3.7 master
git pull https://github.com/GuillaumeSmaha/openapi-generator.git fix_python_3.7

@wing328
Copy link
Member

wing328 commented May 21, 2019

@GuillaumeSmaha to clarify, does your fix (#2884 ) make the Python generator works with Python 3.5 for backward-compatibility?

@GuillaumeSmaha
Copy link
Contributor

@wing328 Yes, I just tried and it works for 3.5. I also fixed a dumb bug 🤦‍♂️ b232d61

@wing328
Copy link
Member

wing328 commented May 30, 2019

@bejohu please try the latest master. Let us know if you still encounter any issue.

@wing328 wing328 closed this May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants