Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Bearer Basic Authorization to Ruby client #2856

Merged
merged 19 commits into from
May 15, 2019
Merged

Add support of Bearer Basic Authorization to Ruby client #2856

merged 19 commits into from
May 15, 2019

Conversation

bopm
Copy link
Contributor

@bopm bopm commented May 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add support of Bearer Basic Authorization to Ruby client.

@bopm
Copy link
Contributor Author

bopm commented May 9, 2019

cc @cliffano @zlx @autopp

@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@bopm
Copy link
Contributor Author

bopm commented May 13, 2019

All formatting issues are covered, but I am struggle to find a way to remove empty lines in generated files.

@bopm
Copy link
Contributor Author

bopm commented May 14, 2019

TravisCI is done, just not updating success here for some reason.

@wing328
Copy link
Member

wing328 commented May 15, 2019

@wing328 wing328 merged commit 8741435 into OpenAPITools:master May 15, 2019
@wing328
Copy link
Member

wing328 commented May 15, 2019

@bopm thanks for the PR 👍

@bopm
Copy link
Contributor Author

bopm commented May 15, 2019

@wing328 looking forward to bring more if ever face same kind of problems. Thanks for all your work on this project!

@wing328
Copy link
Member

wing328 commented Jun 3, 2019

@bopm thanks again for your contribution, which has been included in the v4.0.1 release (https://twitter.com/oas_generator/status/1135534738658062336)

@tonywok
Copy link

tonywok commented Nov 19, 2019

@bopm Hey there, new to open api.

I'd like to take advantage of this feature, but I can't seem to get the generator to produce a client that has the desired auth settings (bearer token).

I'm using a version > v4.0.1. My open api spec is open api version 2.0 -- is this only available in 3.0?

Not sure how to follow the documentation specified here: https://github.com/OpenAPITools/openapi-generator/blob/ccdd56da45cdd7439d6240d3c8018b2c7797d8ed/samples/openapi3/client/petstore/ruby/README.md#bearer_test

@wing328
Copy link
Member

wing328 commented Nov 19, 2019

JWT Bearer is only available in OAS v3.0 but not v2.0.

Ref: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#jwt-bearer-sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants