Skip to content

Add null type only test to Java okhttp-gson client - #24701

Merged
wing328 merged 1 commit into
masterfrom
null-type-only
Aug 14, 2026
Merged

Add null type only test to Java okhttp-gson client#24701
wing328 merged 1 commit into
masterfrom
null-type-only

Conversation

@wing328

@wing328 wing328 commented Aug 14, 2026

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds a null-only schema property to the Java okhttp-gson 3.1 petstore sample to validate OpenAPI 3.1 type: null handling. This ensures the generator emits a nullable Object field and includes it in equality, hashing, and field validation.

  • Spec: adds second_property with type: null and description "just null type".
  • Model PetWithTypesObjectNullAndRef: new secondProperty (Object, @javax.annotation.Nullable), included in equals, hashCode, toString, and openapiFields.
  • Docs: PetWithTypesObjectNullAndRef now lists secondProperty as optional Object with the description.
  • Adds JsonNullable helpers; they are not used and do not change behavior.

Review Notes

  • Focus on generated Java for okhttp-gson to confirm type: null maps to a nullable Object and passes validation.
  • Regenerate samples to verify outputs stay consistent across generators.

Written for commit 9bda43e. Summary will update on new commits.

Review in cubic

@wing328 wing328 changed the title add null type only test o java okhttpgson client Add null type only test o Java okhttp-gson client Aug 14, 2026
@wing328
wing328 marked this pull request as ready for review August 14, 2026 05:34

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/client/petstore/java/okhttp-gson-3.1/src/main/java/org/openapitools/client/model/PetWithTypesObjectNullAndRef.java">

<violation number="1" location="samples/client/petstore/java/okhttp-gson-3.1/src/main/java/org/openapitools/client/model/PetWithTypesObjectNullAndRef.java:166">
P3: The `equalsNullable` and `hashCodeNullable` helper methods are never called, and the `JsonNullable` import exists only to support them. `equals`/`hashCode` use plain `Objects.equals`/`Objects.hash` on the `Object` field, so both helpers are dead code. Remove both methods and the `JsonNullable` import.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Objects.equals(this.additionalProperties, petWithTypesObjectNullAndRef.additionalProperties);
}

private static <T> boolean equalsNullable(JsonNullable<T> a, JsonNullable<T> b) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The equalsNullable and hashCodeNullable helper methods are never called, and the JsonNullable import exists only to support them. equals/hashCode use plain Objects.equals/Objects.hash on the Object field, so both helpers are dead code. Remove both methods and the JsonNullable import.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/java/okhttp-gson-3.1/src/main/java/org/openapitools/client/model/PetWithTypesObjectNullAndRef.java, line 166:

<comment>The `equalsNullable` and `hashCodeNullable` helper methods are never called, and the `JsonNullable` import exists only to support them. `equals`/`hashCode` use plain `Objects.equals`/`Objects.hash` on the `Object` field, so both helpers are dead code. Remove both methods and the `JsonNullable` import.</comment>

<file context>
@@ -133,20 +158,33 @@ public boolean equals(Object o) {
         Objects.equals(this.additionalProperties, petWithTypesObjectNullAndRef.additionalProperties);
   }
 
+  private static <T> boolean equalsNullable(JsonNullable<T> a, JsonNullable<T> b) {
+    return a == b || (a != null && b != null && a.isPresent() && b.isPresent() && Objects.deepEquals(a.get(), b.get()));
+  }
</file context>

@wing328 wing328 changed the title Add null type only test o Java okhttp-gson client Add null type only test to Java okhttp-gson client Aug 14, 2026
@wing328 wing328 added this to the 7.25.0 milestone Aug 14, 2026
@wing328
wing328 merged commit 9a0e7ae into master Aug 14, 2026
165 checks passed
@wing328
wing328 deleted the null-type-only branch August 14, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant