[kotlin-client] Fix enum @JsonCreator to throw for unknown values instead of null, fixes #22662 #22663
+94
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)--
Summary
decode()function with@JsonCreatorto throwIllegalArgumentExceptionfor unknown enum valuesChanges
enum_class.mustacheto throw for unknown values when using JacksonenumUnknownDefaultCaseoptionSummary by cubic
Fix Kotlin client enum deserialization with Jackson: decode(@JsonCreator) now throws IllegalArgumentException for unknown values (and for null when non-nullable). Restores pre-7.18.0 behavior and matches Java client and kotlin-spring; fixes #22662.
Written for commit c97a631. Summary will update on new commits.