Skip to content

Conversation

@limoneren
Copy link
Contributor

@limoneren limoneren commented Jan 10, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. (tagging Kotlin technical committee @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10))
    --

Summary

Changes

  • Modified enum_class.mustache to throw for unknown values when using Jackson
  • Added unit tests for the new behavior
  • Respects enumUnknownDefaultCase option

Summary by cubic

Fix Kotlin client enum deserialization with Jackson: decode(@JsonCreator) now throws IllegalArgumentException for unknown values (and for null when non-nullable). Restores pre-7.18.0 behavior and matches Java client and kotlin-spring; fixes #22662.

  • Bug Fixes
    • Update enum_class.mustache to throw for unknown values; still honors enumUnknownDefaultCase for a default fallback and supports nullable enums.
    • Add tests to verify throwing behavior and the enumUnknownDefaultCase path.
    • Refresh Kotlin samples (spring-restclient and spring-webclient) to reflect the new decode logic.
    • Notes regression origin in v7.18.0 (PR fix(kotlin): add JsonCreator/JsonValue to Jackson enums #22535).

Written for commit c97a631. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@wing328 wing328 added this to the 7.19.0 milestone Jan 12, 2026
@wing328 wing328 merged commit 0da98b0 into OpenAPITools:master Jan 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][kotlin-client] @JsonCreator on enum decode() silently converts invalid values to null (regression in v7.18.0)

2 participants