Skip to content

Conversation

@MelleD
Copy link
Contributor

@MelleD MelleD commented Dec 17, 2025

This PR updates the variable resolution logic in the OpenAPI Generator server template handling. Variables that are prefixed with a $ (e.g. ${server.servlet.context-path}) will no longer be resolved as OpenAPI template variables. Instead, they will be preserved as-is in the generated output.

fixes #22549

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Core-Team please have a look

@wing328
@jimschubert
@cbornet
@jmini
@etherealjoy

@wing328
Copy link
Member

wing328 commented Dec 18, 2025

thanks for the pr

let's give it a try

@wing328 wing328 merged commit 1722f55 into OpenAPITools:master Dec 18, 2025
14 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Dec 18, 2025
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
…templates (OpenAPITools#22550)

* feat: no url replacement  for $ variables

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] Allow usage of Spring properties in server variables for context-path configuration

2 participants