Skip to content

[GO] Generate imports for UnmarshalJSON func only when it's present #22524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Dec 10, 2025
+22 −1
Merged

[GO] Generate imports for UnmarshalJSON func only when it's present #22524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/openapi-generator/src/main/java/org/openapitools/codegen/languages/GoClientCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ public ModelsMap postProcessModels(ModelsMap objs) {
addedFmtImport = true;
}

if (model.hasRequired) {
if (generateUnmarshalJSON && model.hasRequired) {
if (!model.isAdditionalPropertiesTrue &&
(model.oneOf == null || model.oneOf.isEmpty()) &&
(model.anyOf == null || model.anyOf.isEmpty())) {
Expand Down
21 changes: 21 additions & 0 deletions modules/openapi-generator/src/test/java/org/openapitools/codegen/go/GoClientCodegenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,27 @@ public void testVendorExtensionSkipGenerateUnmarshalJson() throws IOException {
"func (o *BaseItem) UnmarshalJSON(data []byte) (err error) {");
}

@Test
public void testNoImportsWithoutUnmarshal() throws IOException {
Map<String, Object> properties = new HashMap<>();
properties.put(CodegenConstants.GENERATE_UNMARSHAL_JSON, false);

File output = Files.createTempDirectory("test").toFile();
output.deleteOnExit();

final CodegenConfigurator configurator = new CodegenConfigurator()
.setGeneratorName("go")
.setAdditionalProperties(properties)
.setInputSpec("src/test/resources/3_0/petstore.yaml")
.setOutputDir(output.getAbsolutePath().replace("\\", "/"));

DefaultGenerator generator = new DefaultGenerator();
List<File> files = generator.opts(configurator.toClientOptInput()).generate();
files.forEach(File::deleteOnExit);

TestUtils.assertFileNotContains(Paths.get(output + "/model_pet.go"), "bytes");
}

@Test
public void testAdditionalPropertiesWithGoMod() throws Exception {
File output = Files.createTempDirectory("test").toFile();
Expand Down
Loading