Skip to content

Conversation

@jwulf
Copy link
Contributor

@jwulf jwulf commented Nov 22, 2025

Fixes #22415.

Use httpx in the generated configuration.py file when httpx is configured as the Python http client library.

@cbornet @tomplus @krjakbrjak @fa0311 could you take a look at this please.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Nov 23, 2025

looks good to me. thanks for the fix.

@wing328 wing328 merged commit ddfcc95 into OpenAPITools:master Nov 23, 2025
46 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Nov 23, 2025
lucy66hw pushed a commit to lucy66hw/openapi-generator that referenced this pull request Dec 16, 2025
* fix: use httpx in generated configuration.py

* fix: add enum_values for httpx

* chore: update petstore samples
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
* fix: use httpx in generated configuration.py

* fix: add enum_values for httpx

* chore: update petstore samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Python] Configuration template unconditionally imports urllib3 when httpx is specified

2 participants