Skip to content

Conversation

@JulianVennen
Copy link
Contributor

@JulianVennen JulianVennen commented Nov 10, 2025

This PR fixes an issue when you have an endpoint that either returns a response with data or an empty response (e.g., empty response on success but an error message on error, or the other way around). The return type would be annotated with the non-empty response types. If an empty response was encountered, null would be returned which throws an error because that's not a valid return type.

I added null to the possible return types if any of the responses have no schema.

Fixes #21359.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon

@wing328 wing328 merged commit d318752 into OpenAPITools:master Nov 10, 2025
23 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Nov 10, 2025
@JulianVennen JulianVennen deleted the php-nextgen-fix-empty-response branch November 10, 2025 14:18
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [php] [php-nextgen] Return type hint does not consider HTTP 204

2 participants