Skip to content

Conversation

jheyens
Copy link
Contributor

@jheyens jheyens commented Oct 14, 2025

In case of an endpoint that may reply with multiple Content-Types where one of them matches a regex checking for JSON-MIME-types (e.g. a file as application/octet-stream if successful and an error message as application/json in case of an error), the Jersey code will ignore all non-JSON MIME-types. This is an issue if the REST-server checks whether user agents are even able to handle the response format by evaluating the "Accept: "-request header (which it should).

I consider this PR a WIP, since there might be reasons for ignoring non-JSON types that I am not aware of.
There also seems to be an issue with three of the petstore samples not being able to handle application/xml (e.g. https://github.com/DIaLOGIKa-GmbH/openapi-generator/actions/runs/18501770033/job/52720236107). I'ld like a discussion on why other MIME-types are discarded and how we could resolve both of these issues.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas
@sreeshas
@jfiala
@lukoyanov
@cbornet
@jeff9finger
@karismann
@Zomzog
@lwlee2608
@martin-mfg

@jheyens jheyens force-pushed the jerseyMultipleAcceptHeader branch 8 times, most recently from 515e130 to e20e33f Compare October 16, 2025 15:51
@jheyens jheyens force-pushed the jerseyMultipleAcceptHeader branch from e20e33f to d6991eb Compare October 16, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant