Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Adjust the names (script, sample folder, generator) to lang option #220

Merged
merged 18 commits into from
Jun 7, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Jun 5, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related issue: #138 (comment)

This PR prefixes the scripts/sample folders/generators with cpp- to avoid users/contributors be confused.

@ackintosh
Copy link
Contributor Author

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/cpp-tizen-petstore.sh writes to old folder

@MartinDelille
Copy link
Contributor

Looks good to me too! Thanks for the contribution!

@ackintosh
Copy link
Contributor Author

@stkrwork Thanks for your comment! fixed it. 👷

@ackintosh
Copy link
Contributor Author

Oh, I noticed that the scripts also exists under bin/openapi3. 👀

@etherealjoy
Copy link
Contributor

Looks good to me.

Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you already mentioned that the scripts in bin/openapi3 also require changing

ackey added 2 commits June 7, 2018 09:06
cpp-restsdk is not exist under bin/openapi3
@ackintosh
Copy link
Contributor Author

Fixed the scripts under bin/openapi3.

@wing328 wing328 merged commit cf657f1 into OpenAPITools:master Jun 7, 2018
@ackintosh ackintosh deleted the issue-138-cpp branch June 7, 2018 08:57
@wing328 wing328 added this to the 3.0.1 milestone Jun 7, 2018
@stkrwork
Copy link
Contributor

stkrwork commented Jun 7, 2018

Did you also look at the restbed and pistache scripts, our C++ servers?

@ackintosh
Copy link
Contributor Author

Oh... I didn't know that restbed and pistache is C++ generator as I'm pretty new to C++. 💦 Thanks for pointing it out. ✨

@etherealjoy
Copy link
Contributor

We can do the pistache and restbed with a different PR. I also forgot.

@ackintosh
Copy link
Contributor Author

I'll file a different PR fixes the issue. 💪

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 8, 2018
* master:
  Add 'unblu inc.' to company list (OpenAPITools#246)
  put company list in alphabetical order (OpenAPITools#244)
  [jaxrs-spec] generate spec file (yaml) correctly (OpenAPITools#243)
  [C++] Adjust the names (script, sample folder, generator) to lang option (OpenAPITools#220)
  Add GMO Pepabo to company list (OpenAPITools#242)
  [Spring] Add apiFirst option (OpenAPITools#184)
  [cli] Write to stdout/stderr, allow redirection (OpenAPITools#207)
  [JAVA][Client] New object instead of null for empty POST request (OpenAPITools#98)
  Make yaml serialization deterministic (OpenAPITools#233)
  Add syntax highlighting to migration guide (OpenAPITools#237)
  Fix shippable badge (OpenAPITools#232)
  update company list (OpenAPITools#227)
  Fix OpenAPITools#210: [Ada] Update the code generator for required and optional parameters (OpenAPITools#211)
  Delete unused methods in DefaultCodegen (OpenAPITools#209)
  add note about maven plugins (OpenAPITools#216)
  add raiffeisen to company list (OpenAPITools#223)
  add a remark about homebrew installatio (OpenAPITools#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants