Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java gson: add @SerializedName value as constant #22

Merged
merged 2 commits into from
May 13, 2018
Merged

Java gson: add @SerializedName value as constant #22

merged 2 commits into from
May 13, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented May 13, 2018

Fix #21.

Run bin/java-petstore-all.sh to update the samples

@wing328 wing328 added this to the 3.0.0 milestone May 13, 2018
@wing328 wing328 merged commit bf7e4e7 into OpenAPITools:master May 13, 2018
@jmini jmini mentioned this pull request May 13, 2018
Closed
@jmini
Copy link
Member Author

jmini commented May 13, 2018

I got an other input from @wing328:

does SERIALIZED_NAME_MapProperty conform to java style guide somehow?

Not exactly, it would be better to write SERIALIZED_NAME_MAP_PROPERTY, but for that we need to expose it in the CodegenProperty. It would be CodegenProperty.nameInSnakeCase similar to CodegenProperty.nameInCamelCase => see Issue #25

@jmini jmini deleted the issue21 branch May 13, 2018 12:06
@jmini jmini mentioned this pull request May 15, 2018
Merged
4 tasks
@jmini
Copy link
Member Author

jmini commented May 15, 2018

Not exactly, it would be better to write SERIALIZED_NAME_MAP_PROPERTY

This is improved with #42

aserkes pushed a commit to aserkes/openapi-generator that referenced this pull request May 30, 2022
@spericas
Merge pull request OpenAPITools#22 from spericas/helidon-client-impro…
b96ed06 
…vements

A few enhancements to the Helidon MP client generator
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
@wing328
Merge pull request OpenAPITools#22 from OpenAPITools/wing328-patch-tmp
3d568f6 
Test package mode in /tmp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Java Enhancement: General
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmini @wing328