-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[python] api client type checks #21935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wing328
merged 1 commit into
OpenAPITools:master
from
artem-ilin:fix-python-type-checks
Sep 10, 2025
Merged
[python] api client type checks #21935
wing328
merged 1 commit into
OpenAPITools:master
from
artem-ilin:fix-python-type-checks
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0e4d9d to
ab15981
Compare
6 tasks
ab15981 to
2dcb9c5
Compare
Contributor
Author
Member
|
thanks for the PR. please review the test failure when you've time. |
4899523 to
0e0262d
Compare
0e0262d to
11bd615
Compare
Contributor
Author
|
@wing328 thank you! I updated the PR, please review. |
Member
|
all tests passed if no one has further feedback, i'll merge it this weekend. thanks for the contribution |
multani
approved these changes
Sep 10, 2025
Contributor
multani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 16, 2025
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21936
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Steps to verify:
output:
output before fix (from master branch):