-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[#21619] fix(python): update pyproject.toml license format with poetry1 fallback #21931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wing328
merged 10 commits into
OpenAPITools:master
from
keepConcentration:support-for-both-string-and-object-license-formats
Sep 10, 2025
Merged
[#21619] fix(python): update pyproject.toml license format with poetry1 fallback #21931
wing328
merged 10 commits into
OpenAPITools:master
from
keepConcentration:support-for-both-string-and-object-license-formats
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toml` for Python and Python-Pydantic generators. (OpenAPITools#21619)
…ct-license-formats' into support-for-both-string-and-object-license-formats
…bject-license-formats
…ct-license-formats' into support-for-both-string-and-object-license-formats
Member
|
Thanks for the PR. cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10) |
Member
|
let's give it a try thanks for the PR |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 16, 2025
…t with poetry1 fallback (OpenAPITools#21931) * Add support for both string and object license formats in `pyproject.toml` for Python and Python-Pydantic generators. (OpenAPITools#21619) * Generate the samples (OpenAPITools#21698) * Generate the samples (OpenAPITools#21698) * Remove Python-Pydantic-v1 license format tests (OpenAPITools#21619) * Revert license format to string in Python-Pydantic-v1 samples (OpenAPITools#21619)
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…t with poetry1 fallback (OpenAPITools#21931) * Add support for both string and object license formats in `pyproject.toml` for Python and Python-Pydantic generators. (OpenAPITools#21619) * Generate the samples (OpenAPITools#21698) * Generate the samples (OpenAPITools#21698) * Remove Python-Pydantic-v1 license format tests (OpenAPITools#21619) * Revert license format to string in Python-Pydantic-v1 samples (OpenAPITools#21619)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21619
This PR fixes the license format in
pyproject.tomlfor the Python generator.pyproject.mustacheto support both legacy (poetry1) and new (Poetry v2+) license formats:PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)