[OCaml] Introduce support for oneOf/anyOf, fix default value for non-required maps
#21798
Conversation
The implementation may not be correct, but at least it compiles. To be checked if someday someone actually uses it/complains.
| let uri = Request.build_uri "/pet/{petId}" in | ||
| let headers = Request.default_headers in | ||
| let headers = Request.maybe_add_header headers "api_key" | ||
|
|
There was a problem hiding this comment.
i'll get this merged first and later maybe come up with a PR to remove these blank lines
curious are you using any linter to format the auto-generated code as part of your development workflow?
There was a problem hiding this comment.
Are you talking about the blank lines in the Mustache files, or in the generated OCaml files?
I think the Mustache files being easy to read is quite important for maintainability 😅
On the other hand, the generated OCaml files being ugly is - in my opinion - not such a big deal because I think almost all projects use a formatter (most often ocamlformat).
I would be happy (probably in another MR) to add an .ocamlformat file + automatically format OCaml files (either directly from openapi-generator but it means it becomes a dependency, or only for the generated files versioned in this Git repo, you tell me)
There was a problem hiding this comment.
Are you talking about the blank lines in the Mustache files, or in the generated OCaml files?
Generated OCaml files
I think the Mustache files being easy to read is quite important for maintainability 😅
Totally agreed.
On the other hand, the generated OCaml files being ugly is - in my opinion - not such a big deal because I think almost all projects use a formatter (most often ocamlformat).
Nice
I would be happy (probably in another MR) to add an .ocamlformat file
Yes, nice to include one
…non-required maps (OpenAPITools#21798) * Add OCaml fake-petstore to test corner cases * Prefix List functions with Stdlib as the fake petstore generates a List module * Handle decimal and any types * Indent to_json.mustache for easier maintenance * Indent api-impl.mustache a bit more for readability before fix * Fix: do not call `to_json` for free forms and byte arrays Fixes OpenAPITools#21312 * Fix compilation for binary types The implementation may not be correct, but at least it compiles. To be checked if someday someone actually uses it/complains. * Indent to_string.mustache * Add support for exploded form-style object query params Fixes OpenAPITools#21307 * Add ocaml-fake-petstore to CI * Fix free-form body params * Cohttp_lwt.Response is deprecated, use Cohttp.Response instead * Safe Java code cleanup * Split into model-record.mustache * Add some support for oneOf/anyOf * Re-generate all OCaml samples * Fix: correctly mark non-required maps with default empty list * Fix: Correctly encode/decode maps * Refresh documentation * Refresh after merging master
2 participants
💡 Review commit by commit for easier review
oneOf/anyOfoneOffeature on some big openapi.json) where non-required maps are missing a@defaultin modelsPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)