-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Swift5][Swift6] support "x-enum-descriptions" #21706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift5][Swift6] support "x-enum-descriptions" #21706
Conversation
|
It looks like the CI step “Run Swift6 tests” is failing in the portion shown below; however, based on the error details, the failure seems unrelated to this PR. |
|
Let me try to close and reopen this PR to restart CI. |
|
@4brunu |
|
CI Failure does seem to be related to this PR. |
|
Thanks for the PR 👍 |
|
Thanks for your review! |
* [swift5] Support x-enum-descriptions * [swift5] Add x-enum-descriptions to test YAML * [swift5] Regenerate samples * [swift6] Support x-enum-descriptions * [swift6] Regenerate samples
Added support for
x-enum-descriptionsin swift5 and swift6.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)