Skip to content

Conversation

@tsutsuken
Copy link
Contributor

@tsutsuken tsutsuken commented Aug 6, 2025

Added support for x-enum-descriptions in swift5 and swift6.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@tsutsuken tsutsuken changed the title [swift5] support "x-enum-descriptions" [swift5, swift6] support "x-enum-descriptions" Aug 6, 2025
@tsutsuken tsutsuken closed this Aug 6, 2025
@tsutsuken tsutsuken reopened this Aug 6, 2025
@tsutsuken tsutsuken changed the title [swift5, swift6] support "x-enum-descriptions" [Swift5][Swift6] support "x-enum-descriptions" Aug 6, 2025
@tsutsuken
Copy link
Contributor Author

tsutsuken commented Aug 6, 2025

It looks like the CI step “Run Swift6 tests” is failing in the portion shown below; however, based on the error details, the failure seems unrelated to this PR.
Please advise if you’d like me to take any follow-up actions.
Thank you.

	Test Suite SwaggerClientTests.xctest started
APIHelperTests
    ✓ testConvertBoolToString (0.004 seconds)
    ✓ testMapValuesToQueryItems (0.004 seconds)
    ✓ testRejectNil (0.001 seconds)
    ✓ testRejectNilHeaders (0.001 seconds)
PetAPITests
    ✓ test1CreatePet (0.377 seconds)
    ✓ test2GetPet (0.075 seconds)
    ✓ test3UploadFile (0.084 seconds)
    ✓ test4DeletePet (0.073 seconds)
StoreAPITests
    ✓ test1PlaceOrder (0.077 seconds)
    ✗ test2GetOrder, failed: caught error: "error(404, Optional(53 bytes), Optional(<NSHTTPURLResponse: 0x60000048c0e0> { URL: https://petstore.swagger.io:443/v2/store/order/1000 } { Status Code: 404, Headers {
    ✓ test3DeleteOrder (0.074 seconds)
UserAPITests
    ✓ test1CreateUser (0.085 seconds)
    ✗ test2GetUser, failed: caught error: "error(404, Optional(52 bytes), Optional(<NSHTTPURLResponse: 0x600000498da0> { URL: https://petstore.swagger.io:443/v2/user/[email protected] } { Status Code: 404, Headers {
    ✓ test3DeleteUser (0.092 seconds)
    ✓ testLogin (0.071 seconds)
    ✓ testLogout (0.079 seconds)

@tsutsuken tsutsuken marked this pull request as ready for review August 6, 2025 10:18
@4brunu
Copy link
Contributor

4brunu commented Aug 6, 2025

Let me try to close and reopen this PR to restart CI.

@4brunu 4brunu closed this Aug 6, 2025
@4brunu 4brunu reopened this Aug 6, 2025
@tsutsuken
Copy link
Contributor Author

@4brunu
Thank you. It’s still failing.
I’ll try closing and reopening this PR to re-trigger CI.

@tsutsuken tsutsuken closed this Aug 7, 2025
@tsutsuken tsutsuken reopened this Aug 7, 2025
@4brunu
Copy link
Contributor

4brunu commented Aug 7, 2025

CI Failure does seem to be related to this PR.

@4brunu
Copy link
Contributor

4brunu commented Aug 7, 2025

Thanks for the PR 👍

@4brunu 4brunu merged commit 5db1e75 into OpenAPITools:master Aug 7, 2025
71 of 74 checks passed
@tsutsuken
Copy link
Contributor Author

Thanks for your review!

@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
* [swift5] Support x-enum-descriptions

* [swift5] Add x-enum-descriptions to test YAML

* [swift5] Regenerate samples

* [swift6] Support x-enum-descriptions

* [swift6] Regenerate samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants