Skip to content

Conversation

@arcueid-dev
Copy link

@arcueid-dev arcueid-dev commented Aug 6, 2025

Added handling for application/octet-stream into template csharp unityWebRequest ApiClient.
Resolves #21703

Unfortunately I was not able to build because of error:

Failed to execute goal org.fortasoft:gradle-maven-plugin:1.0.8:
invoke (default) on project openapi-generator-gradle-plugin-mvn-wrapper: 
org.gradle.tooling.BuildException: Could not execute build using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-7.6.4-bin.zip'.

Solution from here does not yield positive result.

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Aug 6, 2025

that's ok. we will update the samples accordingly

did you test the fix locally to confirm it works for your use cases?

@arcueid-dev
Copy link
Author

that's ok. we will update the samples accordingly

did you test the fix locally to confirm it works for your use cases?

Hi, I tested those changes by inserting them in already generated code.

@wing328
Copy link
Member

wing328 commented Aug 7, 2025

ok. let's give it a try

@wing328 wing328 merged commit c077d00 into OpenAPITools:master Aug 7, 2025
13 of 14 checks passed
@wing328
Copy link
Member

wing328 commented Aug 7, 2025

just merged it. please test the latest master when you've time

@wing328
Copy link
Member

wing328 commented Aug 7, 2025

fyi samples updated via e2652f1

@arcueid-dev arcueid-dev deleted the update-csharp-unitywebrequest branch August 7, 2025 10:24
@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
…ibrary (OpenAPITools#21704)

* Update ApiClient.mustache

* Update ApiClient.mustache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [CSHARP] [UNITYWEBREQUEST] Support Stream for unityWebRequest library

2 participants