[Bug][typescript-fetch] Fix missing close parenthesis in oneOf models. #21645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21639
PR #21464 provided some changes to add serialization & deserialization logic for primitive and enum types used by the ToJSONTypes & FromJSONTyped methods of 'oneOf' models.
There are a couple of cases where the if-statements used in the ToJSONTyped methods generated by the template are missing closing parentheses, such as when serializing an Array, Array.
This PR fixes these cases and modifies the unit test for Issue 21295 to check for the correct number of closing parenthesis.
Just as a side note, having the unit test check for string literals is probably not a great long term strategy as the approach is brittle; changes in formatting which are technically correct can break these tests. It would probably be better to have a tool like assertj (which is used for the Java generation tests) or to use some sort of typescript linting tools to check the output of each test. I took a look at using typescript-eslint, but it seems that that tooling is dependent on running with npm.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Typescript: @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)
PR #21464 - @DavidGrath