[C#] Fixes array TypeDeclaration parsing order to fix deep aliases

[Mattias-Sehlstedt]

fixes: #21605

Adjusts the CSharp TypeDeclarationCodegen to properly parse a deep alias chain (currently it only traverses to a depth of 1). I have used the same structure as the JavaCodegen.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

[devhl-labs]

Thank you for the PR. If this PR is merged we should leave the issue open since there are still some errors after this change. I was going to make this code from the abstract recursive to fix the remaining generic issues, but it seems like a work around to a bug. Maybe you know a better way.

        String[] nestedTypes = {"List", "Collection", "ICollection", "Dictionary"};

        Arrays.stream(nestedTypes).forEach(nestedType -> {
            // fix incorrect data types for maps of maps
            if (property.datatypeWithEnum.contains(", " + nestedType + ">") && property.items != null) {
                property.datatypeWithEnum = property.datatypeWithEnum.replace(", " + nestedType + ">", ", " + property.items.datatypeWithEnum + ">");
                property.dataType = property.datatypeWithEnum;
            }

            if (property.datatypeWithEnum.contains("<" + nestedType + ">") && property.items != null) {
                property.datatypeWithEnum = property.datatypeWithEnum.replace("<" + nestedType + ">", "<" + property.items.datatypeWithEnum + ">");
                property.dataType = property.datatypeWithEnum;
            }
        });

[Mattias-Sehlstedt]

The author of the original issue was not very elaborate on exactly what issues they faced.

I have created a separate issue for the deep alias problem which I have attempted to fix. I have updated the PR description to refer to that issue instead.

[wing328]

thanks for the pr

let's give it a try