Skip to content

Conversation

@DavidGrath
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@martin-mfg
@lwlee2608
Please help review for Java

@DavidGrath
Copy link
Contributor Author

@wing328 @martin-mfg , please do you have any advise on how to handle GlobalSettingsTest.testNonStringSystemProperties? I see that's the test causing the pipeline failure

@wing328
Copy link
Member

wing328 commented Jun 18, 2025

i think that's resolved in the latest master

can you please merge the latest master into your branch?

@DavidGrath
Copy link
Contributor Author

@wing328 , thank you! It's fixed now

@wing328 wing328 merged commit b05604d into OpenAPITools:master Jun 26, 2025
14 checks passed
@wing328
Copy link
Member

wing328 commented Jun 26, 2025

thanks for the PR

let's give it a try

@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants