Skip to content

[python] Validate pyproject.toml and fix the pyproject.toml version constraint format #21402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 7 commits into from
Jun 18, 2025
Merged

[python] Validate pyproject.toml and fix the pyproject.toml version constraint format #21402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a0cc3f0
Validate pyproject.toml of echo client python sample
4c0n Jun 10, 2025
cd65e5c
Use PEP-508 compatible version constraint for `requires-python` key
4c0n Jun 10, 2025
e1f87b1
Update samples
4c0n Jun 10, 2025
d390170
Move job to petstore workflow
4c0n Jun 11, 2025
c3c8d99
Update generated sample
4c0n Jun 11, 2025
557a112
Use equals or greater than operator instead of greater than
4c0n Jun 12, 2025
a7cb586
Update samples
4c0n Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/samples-python-petstore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@ on:
- .github/workflows/samples-python-petstore.yaml

jobs:
validate-pyproject-toml:
name: Validate pyproject.toml
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.13"
- name: Install validator
run: pip install 'validate-pyproject[all]'
- name: Validate
run: validate-pyproject samples/openapi3/client/petstore/python/pyproject.toml
build:
name: Test Python client
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/python/pyproject.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pydantic = ">= 2"
typing-extensions = ">= 4.7.1"
{{/poetry1}}
{{^poetry1}}
requires-python = "^3.9"
requires-python = ">=3.9"

dependencies = [
"urllib3 (>=2.1.0,<3.0.0)",
Expand Down
2 changes: 1 addition & 1 deletion samples/client/echo_api/python-disallowAdditionalPropertiesIfNotPresent/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ authors = [
license = "Apache 2.0"
readme = "README.md"
keywords = ["OpenAPI", "OpenAPI-Generator", "Echo Server API"]
requires-python = "^3.9"
requires-python = ">=3.9"

dependencies = [
"urllib3 (>=2.1.0,<3.0.0)",
Expand Down
2 changes: 1 addition & 1 deletion samples/client/echo_api/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ authors = [
license = "Apache 2.0"
readme = "README.md"
keywords = ["OpenAPI", "OpenAPI-Generator", "Echo Server API"]
requires-python = "^3.9"
requires-python = ">=3.9"

dependencies = [
"urllib3 (>=2.1.0,<3.0.0)",
Expand Down
2 changes: 1 addition & 1 deletion samples/openapi3/client/petstore/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ authors = [
license = "Apache-2.0"
readme = "README.md"
keywords = ["OpenAPI", "OpenAPI-Generator", "OpenAPI Petstore"]
requires-python = "^3.9"
requires-python = ">=3.9"

dependencies = [
"urllib3 (>=2.1.0,<3.0.0)",
Expand Down
Loading