Skip to content

Conversation

@andrewwilsonnew
Copy link

@andrewwilsonnew andrewwilsonnew commented Jun 5, 2025

Found a couple of bugs (so can we include this in the branch release)

  • void return from Action should be Response<Void>
  • Array type should be List in Misk
  • File -> Response<ByteString>

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@andrewwilsonnew andrewwilsonnew changed the title first pass Fix MiskKotlin OpenApiGenerator types Jun 5, 2025
@andrewwilsonnew andrewwilsonnew marked this pull request as ready for review June 5, 2025 19:31
@andrewwilsonnew andrewwilsonnew marked this pull request as draft June 5, 2025 20:21
@andrewwilsonnew
Copy link
Author

Based off wrong branch, so recreated here : #21390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant