fix(cpp-qt-client): add asJsonObject method to OAIEnum class (#19307) #21211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you explain the need for this new method ? Also, you would need to re-generate the example if you want the PR to be merge. |
Contributor
Author
|
@MartinDelille This PR adds the missing asJsonObject method to the Enum class. When generating the schema for enums, the generated client code does not compile with my FastAPI schemas that use enums, as the client is expecting this method. The issue is also reported by another person here: #19307 I've generated and pushed the examples. |
MartinDelille
approved these changes
May 6, 2025
Contributor
MartinDelille
left a comment
MartinDelille
left a comment
There was a problem hiding this comment.
Thank you for you for your edit and your explanation. I indeed don't use edit and had trouble using it one time in the past!
ReallyVirtual
force-pushed
the
fix-cpp-qt-enum-asjsonobject
branch
from
988e125 to
543675d
Compare
wing328
reviewed
May 9, 2025
samples/client/petstore/rust/hyper/petstore/src/models/duplicate_one_of.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the fix @wing328 - @MartinDelille: the CI checks are passing now, please reapprove if necessary. |
…qt-enum-asjsonobject
ReallyVirtual
added a commit
to ReallyVirtual/openapi-generator
that referenced
this pull request
Sep 2, 2025
…nd referenced enums
For enum query parameters, the template was incorrectly using asJsonObject()
which returns {"value": "enumValue"} and then iterating over keys, using
"value" as the parameter name instead of the actual parameter name.
This fix adds special handling for both inline enums (isEnum) and referenced
enums (isEnumRef) to use asJson() directly, which returns the correct enum
string value for URL serialization.
Fixes enum query parameters like ?scope=property instead of ?value=property.
Completes the fix started in PR OpenAPITools#21211 which added the asJsonObject() method
to make enum code compile, but the template logic was still incorrect for URL
query parameter serialization.
Note: The petstore samples don't contain enum query parameter tests to
demonstrate this fix (they use string arrays). Future contributors may want
to add enum query parameter examples to better showcase this functionality.
Open
2 tasks
wing328
added a commit
that referenced
this pull request
Dec 18, 2025
…nd referenced enums (#22559) * fix(cpp-qt): Fix enum query parameter serialization for both inline and referenced enums For enum query parameters, the template was incorrectly using asJsonObject() which returns {"value": "enumValue"} and then iterating over keys, using "value" as the parameter name instead of the actual parameter name. This fix adds special handling for both inline enums (isEnum) and referenced enums (isEnumRef) to use asJson() directly, which returns the correct enum string value for URL serialization. Fixes enum query parameters like ?scope=property instead of ?value=property. Completes the fix started in PR #21211 which added the asJsonObject() method to make enum code compile, but the template logic was still incorrect for URL query parameter serialization. Note: The petstore samples don't contain enum query parameter tests to demonstrate this fix (they use string arrays). Future contributors may want to add enum query parameter examples to better showcase this functionality. * add tests for enum inline, ref for query parameters * update cmake version to 3.5 --------- Co-authored-by: Sohaib Athar <[email protected]>
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…nd referenced enums (OpenAPITools#22559) * fix(cpp-qt): Fix enum query parameter serialization for both inline and referenced enums For enum query parameters, the template was incorrectly using asJsonObject() which returns {"value": "enumValue"} and then iterating over keys, using "value" as the parameter name instead of the actual parameter name. This fix adds special handling for both inline enums (isEnum) and referenced enums (isEnumRef) to use asJson() directly, which returns the correct enum string value for URL serialization. Fixes enum query parameters like ?scope=property instead of ?value=property. Completes the fix started in PR OpenAPITools#21211 which added the asJsonObject() method to make enum code compile, but the template logic was still incorrect for URL query parameter serialization. Note: The petstore samples don't contain enum query parameter tests to demonstrate this fix (they use string arrays). Future contributors may want to add enum query parameter examples to better showcase this functionality. * add tests for enum inline, ref for query parameters * update cmake version to 3.5 --------- Co-authored-by: Sohaib Athar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add asJsonObject method to OAIEnum class for cpp-qt-client
Adds the missing method to enum moustache file
@etherealjoy @MartinDelille