[fix][elixir] wrong typespec generation for all-of with single ref #21139
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,60 @@ defmodule OpenapiPetstore.Api.Fake do | |
| alias OpenapiPetstore.Connection | ||
| import OpenapiPetstore.RequestBuilder | ||
|
|
||
| @doc """ | ||
|
|
||
| ### Parameters | ||
|
|
||
| - `connection` (OpenapiPetstore.Connection): Connection to server | ||
| - `opts` (keyword): Optional parameters | ||
|
|
||
| ### Returns | ||
|
|
||
| - `{:ok, OpenapiPetstore.Model.Foo.t}` on success | ||
| - `{:error, Tesla.Env.t}` on failure | ||
| """ | ||
| @spec fake_all_of_with_local_single_ref_get(Tesla.Env.client, keyword()) :: {:ok, any()} | {:error, Tesla.Env.t} | ||
| def fake_all_of_with_local_single_ref_get(connection, _opts \\ []) do | ||
| request = | ||
| %{} | ||
| |> method(:get) | ||
| |> url("/fake/all-of-with-local-single-ref") | ||
| |> Enum.into([]) | ||
|
|
||
| connection | ||
| |> Connection.request(request) | ||
| |> evaluate_response([ | ||
| {200, OpenapiPetstore.Model.Foo} | ||
| ]) | ||
| end | ||
|
|
||
| @doc """ | ||
|
|
||
| ### Parameters | ||
|
|
||
| - `connection` (OpenapiPetstore.Connection): Connection to server | ||
| - `opts` (keyword): Optional parameters | ||
|
|
||
| ### Returns | ||
|
|
||
| - `{:ok, OpenapiPetstore.Model.AllOfWithSingleRef.t}` on success | ||
| - `{:error, Tesla.Env.t}` on failure | ||
| """ | ||
| @spec fake_all_of_with_remote_single_ref_get(Tesla.Env.client, keyword()) :: {:ok, OpenapiPetstore.Model.AllOfWithSingleRef.t} | {:error, Tesla.Env.t} | ||
| def fake_all_of_with_remote_single_ref_get(connection, _opts \\ []) do | ||
| request = | ||
| %{} | ||
| |> method(:get) | ||
| |> url("/fake/all-of-with-remote-single-ref") | ||
| |> Enum.into([]) | ||
|
|
||
| connection | ||
| |> Connection.request(request) | ||
| |> evaluate_response([ | ||
| {200, OpenapiPetstore.Model.AllOfWithSingleRef} | ||
| ]) | ||
| end | ||
|
|
||
| @doc """ | ||
| for Java apache and Java native, test toUrlQueryString for maps with BegDecimal keys | ||
|
|
||
|
|
@@ -180,14 +234,14 @@ defmodule OpenapiPetstore.Api.Fake do | |
|
|
||
| - `connection` (OpenapiPetstore.Connection): Connection to server | ||
| - `opts` (keyword): Optional parameters | ||
| - `:body` (number()): Input number as post body | ||
|
Contributor
Author
There was a problem hiding this comment.
|
||
|
|
||
| ### Returns | ||
|
|
||
| - `{:ok, number()}` on success | ||
| - `{:error, Tesla.Env.t}` on failure | ||
| """ | ||
| @spec fake_outer_number_serialize(Tesla.Env.client, keyword()) :: {:ok, number()} | {:error, Tesla.Env.t} | ||
| def fake_outer_number_serialize(connection, opts \\ []) do | ||
| optional_params = %{ | ||
| :body => :body | ||
|
|
@@ -464,7 +518,7 @@ defmodule OpenapiPetstore.Api.Fake do | |
| ### Parameters | ||
|
|
||
| - `connection` (OpenapiPetstore.Connection): Connection to server | ||
| - `number` (number()): None | ||
| - `double` (float()): None | ||
| - `pattern_without_delimiter` (String.t): None | ||
| - `byte` (binary()): None | ||
|
|
@@ -485,7 +539,7 @@ defmodule OpenapiPetstore.Api.Fake do | |
| - `{:ok, nil}` on success | ||
| - `{:error, Tesla.Env.t}` on failure | ||
| """ | ||
| @spec test_endpoint_parameters(Tesla.Env.client, number(), float(), String.t, binary(), keyword()) :: {:ok, nil} | {:error, Tesla.Env.t} | ||
| def test_endpoint_parameters(connection, number, double, pattern_without_delimiter, byte, opts \\ []) do | ||
| optional_params = %{ | ||
| :integer => :form, | ||
|
|
@@ -623,7 +677,7 @@ defmodule OpenapiPetstore.Api.Fake do | |
| ### Parameters | ||
|
|
||
| - `connection` (OpenapiPetstore.Connection): Connection to server | ||
| - `body` (map()): request body | ||
| - `opts` (keyword): Optional parameters | ||
|
|
||
| ### Returns | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more idiomatic and allows us to better identify what schemas may need a custom model doing something along the lines of
languageSpecificPrimitives.contains(type)