-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Fixed Rust model files not matching module imports causing compiler errors #21134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Rust model files not matching module imports causing compiler errors #21134
Conversation
|
please update the samples when you've time |
cc9d92d to
a82635d
Compare
|
oops, sorry about that. I thought I update updated them but I guess not. |
|
No problem. Thanks for the contributions as always. Have a nice weekend |
|
@ross-paypay @wing328 the PR has introduced files with the same case-insensitive names. Can this be corrected? |
|
@gcatanese Can you provide steps to reproduce? |
|
@ross-paypay I'm using a Window box and I'm able to repeat the issue with git bash |
Fixes an issue when there are 2 models with the same name but different capitalization for Rust clients.
Partially fixes, #21078
The implementation is a simplified version of what the KotlinClientCodegen is doing
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro