Skip to content

fix: Support PathParams not of primitive types for Go in generated tests #21107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Apr 25, 2025
Merged

fix: Support PathParams not of primitive types for Go in generated tests #21107

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c8b155
fix: Support PathParams not of primitive types for Go in generated tests
madpah Apr 17, 2025
a224c98
use tabs consistently
madpah Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/openapi-generator/src/main/resources/go/api_test.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ func Test_{{packageName}}_{{classname}}Service(t *testing.T) {
t.Skip("skip test") // remove to run test

{{/-first}}
{{#isPrimitiveType}}

@wing328 wing328 Apr 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're using a mix of tabs and spaces for indentation

what about replacing spaces above with tabs instead to make it consistent with the rest of the template?

@madpah madpah Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @wing328

var {{paramName}} {{{dataType}}}
{{/isPrimitiveType}}
{{^isPrimitiveType}}
var {{paramName}} {{goImportAlias}}.{{{dataType}}}
{{/isPrimitiveType}}
{{/pathParams}}

{{#returnType}}resp, {{/returnType}}httpRes, err := apiClient.{{classname}}.{{operationId}}(context.Background(){{#pathParams}}, {{paramName}}{{/pathParams}}).Execute()
Expand Down