-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[swift6] Change JSONEncodable protocol to always return String #20906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't know why the test is failing. It seems the test output itself is broken? |
|
Hi @x-sheep, thanks for creating this PR, this is a nice contribution. By building this locally I got the following errors: |
|
Since we are having some problems with the server returning some errors, you can try to build the sample projects locally by commenting the following lines (please don't commit this change).
And then you can run the following command in the terminal to build all the swift sample projects. |
|
Now it builds locally. |
|
@x-sheep thanks for the PR when you've time, can you please PM me via Slack for a quick chat? https://join.slack.com/t/openapi-generator/shared_invite/zt-2wmkn4s8g-n19PJ99Y6Vei74WMUIehQA |
By no longer using
Anyas a type, we can assert that all parameter dictionaries are Sendable. This allows upgrading Alamofire to the latest version.Fixes #20398
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)