Skip to content

Conversation

@jarangutan
Copy link
Contributor

Related to #20817

Missed moving the errMsgs from the router to the helper file in this MR: #20823

Apologies about that! This MR is to complete the move so everything helper is together and router is standalone

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

@wing328
Copy link
Member

wing328 commented Mar 14, 2025

thanks for the follow-up PR

quick question: shouldn't the current output (go code) fail to compile if these constants are missing?

@jarangutan
Copy link
Contributor Author

jarangutan commented Mar 14, 2025

They won't be missing, they'll be in the helper file instead of router since the helper code is using it.

But yeah, if I was deleting them then go would throw an error for vars not existing when it went to compile. It would have also been caught by the tests since go compiles then too

Their placement works in any of these files since they're part of the package. That's why the version in master still works since helper file can use the vars in router file.

@wing328
Copy link
Member

wing328 commented Mar 14, 2025

thanks for the explanation

will merge it over the weekend if no one else has further feedback/question

@wing328 wing328 added Server: Go Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Mar 14, 2025
@wing328 wing328 added this to the 7.13.0 milestone Mar 14, 2025
@wing328 wing328 merged commit b1f572e into OpenAPITools:master Mar 15, 2025
20 checks passed
@jarangutan
Copy link
Contributor Author

Thank you @wing328 !
Appreciate the partnership ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants