Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Mar 11, 2025

fix operationId mapping using the original operationid

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cbascom
Copy link
Contributor

cbascom commented Mar 11, 2025

I like this change since manually converting these names from specs is very annoying :). Any concern with this being a breaking change for anyone that already has configs set up that rely on the old logic though?

@wing328
Copy link
Member Author

wing328 commented Mar 12, 2025

Any concern with this being a breaking change for anyone that already has configs set up that rely on the old logic though?

good question.

they can update the mapping names accordingly.

we consider this as a bug fix as all these name mapping options intent to work with the original values provided in the spec.

@wing328 wing328 marked this pull request as ready for review March 12, 2025 08:49
@wing328 wing328 merged commit 3ab495a into master Mar 12, 2025
16 of 17 checks passed
@wing328 wing328 deleted the operationid-fix branch March 12, 2025 12:28
kpy3 pushed a commit to kpy3/openapi-generator that referenced this pull request Mar 13, 2025
* fix operationId mapping

* add tests

* minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants