-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix #20649 Handling of x-implements for enumeration in java and spring generators #20652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
5ac75eb
4e64324
81b474a
b4833ad
e94e037
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| openapi: 3.0.0 | ||
| info: | ||
| title: Sample API | ||
| description: API description in Markdown. | ||
| version: 1.0.0 | ||
| paths: | ||
| /ponies: | ||
| get: | ||
| summary: Returns all animals. | ||
| description: Optional extended description in Markdown. | ||
| responses: | ||
| 200: | ||
| description: OK | ||
| content: | ||
| application/json: | ||
| schema: | ||
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/Pony' | ||
| components: | ||
| schemas: | ||
| Pony: | ||
| type: object | ||
| properties: | ||
| type: | ||
| $ref: '#/components/schemas/Type' | ||
| Type: | ||
| type: string | ||
| x-implements: org.openapitools.java.EnumInterface | ||
| enum: | ||
| - Earth | ||
| - Pegasi | ||
| - Unicorn |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ | |
| * Gets or Sets EnumClass | ||
| */ | ||
| @JsonAdapter(EnumClass.Adapter.class) | ||
| public enum EnumClass { | ||
| public enum EnumClass implements Parcelable { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change and the change in OuterEnum.java cause compilation errors. Skipping this line for enums should be enough to fix the problem.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the review. I'll have a look
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @martin-mfg I had a merge problem I've created a new PR #20778 Sorry for the inconvenience |
||
|
|
||
| _ABC("_abc"), | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
SpringCodegen.