Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Go-server] invalid composite literal type string #20467

Conversation

vingarzan
Copy link
Contributor

@vingarzan vingarzan commented Jan 14, 2025

The patch does an alternative initialization of a Go-lang variable, such that a custom pre-check and multiple alternative := initialization would be needed in the mustache template. This fixes #17373 which would generate invalid code like:

  nameParam := string{} // error: "invalid composite literal type string"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

@wing328
Copy link
Member

wing328 commented Jan 14, 2025

thanks for the PR.

what about adding a test or 2 to the test spec (modules/openapi-generator/src/test/resources/3_0/go-server/petstore.yaml) and regenerate the samples so that the issue is covered moving forward?

@vingarzan
Copy link
Contributor Author

TBH, I'm super new to this project and quite rusty in Java, so I have no clue where/what to add. Maybe if we'd add to the PetStore example some data structure which would trigger this?

@wing328
Copy link
Member

wing328 commented Jan 15, 2025

i added some tests via #20474

and tested your change locally to confirm the fix.

thanks for the PR.

will merge #20474 after merging your fix.

@wing328 wing328 merged commit dcf472a into OpenAPITools:master Jan 15, 2025
16 checks passed
@wing328 wing328 changed the title ISSUE: #17373 [BUG] [Go-server] invalid composite literal type string [BUG] [Go-server] invalid composite literal type string Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Go-server] invalid composite literal type string
2 participants