Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin][client] add option to support non-ascii headers in okhttp #20331

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Dec 14, 2024

Fixes #20330

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
tersmitten Mischa ter Smitten
@Djaler Djaler force-pushed the kotlin-non-ascii-headers branch from af16d49 to af1da3c Compare December 14, 2024 19:06
@wing328
Copy link
Member

wing328 commented Dec 15, 2024

@Djaler thanks for the PR.

Do we need an option for this change? In other words, using the non ascii method should work for both ascii and non ascii input, right?

@Djaler
Copy link
Contributor Author

Djaler commented Dec 15, 2024

Guy from okhttp said Please use only ASCII characters in your headers. If you are interoperaring with a system that incorrectly uses other characters, use addUnsafeNonAscii() on Headers.Builder. square/okhttp#6347 (comment)

@Djaler
Copy link
Contributor Author

Djaler commented Dec 15, 2024

So, technically, we can enable this by default, but I don't sure if we should

@wing328
Copy link
Member

wing328 commented Dec 15, 2024

I see. thanks for the explanation.

we can go with what you've so far

thanks again for the PR

@wing328 wing328 merged commit 4e5a828 into OpenAPITools:master Dec 15, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Kotlin] java.lang.IllegalArgumentException: Unexpected char when using non-ascii chars in headers
2 participants